Re: [PATCH 08/21] header: backport devm_acpi_dev_add_driver_gpios()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2017-09-06 at 23:58 +0200, Hauke Mehrtens wrote:
> 
> > This I don't understand - you said it's hard to do for <3.19, and
> > then
> > make a simple no-op for all, but don't do it for <3.19 at all?
> > 
> > Why not just LINUX_VERION_LESS(4,13,0)?
> 
> struct acpi_gpio_mapping was added to kernel 3.19. We could add here
> a dummy struct acpi_gpio_mapping, but the drivers anyway need more
> adjustments to compile properly.

Ok.

> > > +#define devm_acpi_dev_add_driver_gpios
> > > LINUX_BACKPORT(devm_acpi_dev_add_driver_gpios)
> > > +static inline int devm_acpi_dev_add_driver_gpios(struct device
> > > *dev,
> > > +			      const struct acpi_gpio_mapping
> > > *gpios)
> > > +{
> > > +	return -ENXIO;
> > > +}
> > > +#endif /* LINUX_VERSION_IN_RANGE(4,19,0, 4,13,0) */
> 
> This should be
> +#endif /* LINUX_VERSION_IN_RANGE(3,19,0, 4,13,0) */

Right. I'll fix this and apply then.

johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux