Re: [PATCH 1/2] backports: add definition for USB_SPEED_SUPER_PLUS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10-7-2016 23:16, Hauke Mehrtens wrote:
> On 06/05/2016 11:30 AM, Arend van Spriel wrote:
>> Speed definition for usb3.1 has been added in 4.6 kernel. Add
>> definiton for older kernels.
>>
>> Signed-off-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>
>> ---
>>  backport/backport-include/linux/usb/ch9.h | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/backport/backport-include/linux/usb/ch9.h b/backport/backport-include/linux/usb/ch9.h
>> index 135e24c..c42fc30 100644
>> --- a/backport/backport-include/linux/usb/ch9.h
>> +++ b/backport/backport-include/linux/usb/ch9.h
>> @@ -21,4 +21,8 @@ static inline int usb_endpoint_maxp(const struct usb_endpoint_descriptor *epd)
>>  }
>>  #endif /* < 3.2 */
>>  
>> +#if LINUX_VERSION_CODE < KERNEL_VERSION(4,6,0)
>> +#define USB_SPEED_SUPER_PLUS	(USB_SPEED_SUPER + 1)
>> +#endif /* < 4.6 */
>> +
>>  #endif /* __BACKPORT__LINUX_USB_CH9_H */
>>
> 
> This is in a emum in the mainline kernel. I think this will cause some
> warnings when backporting it this way.

The way it is used in brcmfmac I do not get a warning, but I agree it
would not work if this value is used calling a function that expects
enum usb_device_speed. So how would you backport this?

Regards,
Arend
--
To unsubscribe from this list: send the line "unsubscribe backports" in



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux