Fwd: Re: [PATCH] Bluetooth: hci_ldisc: backport changes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi!

Wanted to send a patch including version checking upstream to the bluetooth guys - but wasn't accepted, see below.

Now your README in the patches folder says that new patches are not usually acceptable on your side.

What would be the right approach to get the below define statements into the backports?

Regards,

Florian

-------- Forwarded Message --------
Subject: Re: [PATCH] Bluetooth: hci_ldisc: backport changes
Date: Fri, 26 Jun 2015 20:30:15 +0200
From: Marcel Holtmann <marcel@xxxxxxxxxxxx>
To: Florian Grandel <fgrandel@xxxxxxxxx>
CC: linux-bluetooth@xxxxxxxxxxxxxxx

Hi Florian,

The references to tty->termios in hci_ldisc were not backports
compatible. Introducing #define statements to make this file compile
against earlier kernel versions.

Signed-off-by: Florian Grandel <fgrandel@xxxxxxxxx>
---
drivers/bluetooth/hci_ldisc.c | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c
index 177dd69..14d08b1 100644
--- a/drivers/bluetooth/hci_ldisc.c
+++ b/drivers/bluetooth/hci_ldisc.c
@@ -24,6 +24,7 @@
 */

#include <linux/module.h>
+#include <linux/version.h>

#include <linux/kernel.h>
#include <linux/init.h>
@@ -277,7 +278,11 @@ void hci_uart_set_flow_control(struct hci_uart *hu, bool enable)

	if (enable) {
		/* Disable hardware flow control */
+#if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,7,0))
		ktermios = tty->termios;
+#else
+		ktermios = *tty->termios;
+#endif

such a patch is not acceptable upstream. This is something that the backports projects has to keep out-of-tree.

Regards

Marcel




--
To unsubscribe from this list: send the line "unsubscribe backports" in



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux