On Mon, Jun 8, 2015 at 12:45 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Mon, 2015-06-08 at 12:31 -0700, Luis R. Rodriguez wrote: > >> This is true, its in the like of how we wrote pycocci to provide us >> with a multithreaded solution for spatch integration / development as >> well and how pycocci now is upstream on Coccinelle. > > Speaking of which - are you aware that pycocci fails (or rather doesn't > fail!) miserably when cocci isn't installed/in the $PATH? At least I got > a report to that extent, Did you verify it? > that it didn't really complete nor report an error in that case. Definitely not. Error reporting from pycocci's use of Coccinelle use sucked though because it was adding extra spaces in between each character though, I just fixed that last week, will sync now. Patches / reports for issues are welcome but please note that pycocci is now part of Coccinelle so issues / patches should copy that list. For a while I'll just keep these in sync for convenience given that Coccinelle tends to batch a few commits before a release is made. I'll sync up now though. mcgrof@ergon ~/linux-next (git::20150604-proto_ops-send-rcv-smpl)$ which pycocci which: no pycocci in (/usr/local/bin/:/usr/local/sbin/:/sbin/:/usr/sbin/:/home/mcgrof/bin/:/usr/bin:/usr/local/bin/:/usr/local/sbin/:/sbin/:/usr/sbin/:/home/mcgrof/bin/:/usr/bin:/usr/local/bin/:/usr/local/sbin/:/sbin/:/usr/sbin/:/home/mcgrof/bin/:/usr/bin:/home/mcgrof/bin:/usr/local/bin:/usr/bin:/bin:/usr/bin/X11:/usr/games) So not on my path. mcgrof@ergon ~/linux-next (git::20150604-proto_ops-send-rcv-smpl)$ /home/mcgrof/devel/coccinelle/tools/pycocci 0002-no_dmabuf.cocci drivers/media/v4l2-core/videobuf2-dma-contig.c spatch --sp-file 0002-no_dmabuf.cocci --in-place --recursive-includes --relax-include-path --use-coccigrep --timeout 120 --dir drivers/media/v4l2-core/videobuf2-dma-contig.c -max 4 -index 0 spatch --sp-file 0002-no_dmabuf.cocci --in-place --recursive-includes --relax-include-path --use-coccigrep --timeout 120 --dir drivers/media/v4l2-core/videobuf2-dma-contig.c -max 4 -index 1 spatch --sp-file 0002-no_dmabuf.cocci --in-place --recursive-includes --relax-include-path --use-coccigrep --timeout 120 --dir drivers/media/v4l2-core/videobuf2-dma-contig.c -max 4 -index 2 spatch --sp-file 0002-no_dmabuf.cocci --in-place --recursive-includes --relax-include-path --use-coccigrep --timeout 120 --dir drivers/media/v4l2-core/videobuf2-dma-contig.c -max 4 -index 3 and git diff yields exact same results as if when pycocci is in my path. Please have the user report the issue to this list and copy the cocci list. Also Johannes, I value your time and I feel you're investing quite a bit of time into this NACK discussion, I obviously trust your judgement completely on gentree.py maintenance so for your convenience feel free to be concise in your NACK's for patches there. Luis -- To unsubscribe from this list: send the line "unsubscribe backports" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
