Re: [PATCH v2 2/2] backport: add hwmon group registration functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/25/2015 06:46 PM, Mathieu Olivari wrote:
> hwmon group registration functions have been added in 3.13 kernel.
> Latest ath10k patches make use of this mechanism, therefore the
> need for the backport.
> 
> Signed-off-by: Mathieu Olivari <mathieu@xxxxxxxxxxxxxxxx>
> 
> ---
>  backport/backport-include/linux/hwmon.h |   34 ++++++++++++++++++++
>  backport/compat/backport-3.13.c         |   52 +++++++++++++++++++++++++++++++
>  2 files changed, 86 insertions(+)
>  create mode 100644 backport/backport-include/linux/hwmon.h
> 
> Notes:
>     v2: address the comments reported by Hauke
>     *make devm_hwmon_release() static and moved it above
>      devm_hwmon_device_register_with_group()
>     *moved new includes at the top of the file
>     *set dev->groups and drvdata in hwmon_device_register_with_groups()
> 

Thank you for the patches. Both were applied to backports and added to
the latest release.

> +	struct device *hwdev;
> +
> +	hwdev = hwmon_device_register(dev);
> +	hwdev->groups = groups;
> +	dev_set_drvdata(&hwdev, drvdata);

I did a small change to this line. hwdev should not be given by double
reference here. I removed the &.

Hauke
--
To unsubscribe from this list: send the line "unsubscribe backports" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux