Re: [PATCH 1/3] backports: add GENMASK and GENMASK_ULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/13/2014 09:49 PM, Felix Fietkau wrote:
> I intend to use this for a new driver
> 
> Signed-off-by: Felix Fietkau <nbd@xxxxxxxxxxx>
> ---
>  backport/backport-include/linux/bitops.h | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  create mode 100644 backport/backport-include/linux/bitops.h
> 
> diff --git a/backport/backport-include/linux/bitops.h b/backport/backport-include/linux/bitops.h
> new file mode 100644
> index 0000000..d8aec05
> --- /dev/null
> +++ b/backport/backport-include/linux/bitops.h
> @@ -0,0 +1,19 @@
> +#ifndef __BACKPORT_BITOPS_H
> +#define __BACKPORT_BITOPS_H
> +#include_next <linux/bitops.h>
> +#include <linux/version.h>
> +#include <generated/utsrelease.h>

These two includes are not needed.

> +
> +#ifndef GENMASK
> +
> +/*
> + * Create a contiguous bitmask starting at bit position @l and ending at
> + * position @h. For example
> + * GENMASK_ULL(39, 21) gives us the 64bit vector 0x000000ffffe00000.
> + */
> +#define GENMASK(h, l)          (((U32_C(1) << ((h) - (l) + 1)) - 1) << (l))
> +#define GENMASK_ULL(h, l)      (((U64_C(1) << ((h) - (l) + 1)) - 1) << (l))

You should use tabs here and not spaces.

> +
> +#endif
> +
> +#endif /* __BACKPORT_BITOPS_H */
> 

--
To unsubscribe from this list: send the line "unsubscribe backports" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux