On Wed, Oct 29, 2014 at 12:49 AM, Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx> wrote: > Since > > commit de427857852e7194b9ae80571425ba0d2c29ef55 > Author: Luis R. Rodriguez <mcgrof@xxxxxxxx> > Date: Sun Sep 14 06:05:29 2014 -0700 > > backports: fix mconf compilation library assumptions > > I can't compile mconf on my Ubuntu trusty machine. > This fixes that by making Luis's patch conditional. > > Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx> > --- > backport/kconf/Makefile | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/backport/kconf/Makefile b/backport/kconf/Makefile > index dfd793a..8398f35 100644 > --- a/backport/kconf/Makefile > +++ b/backport/kconf/Makefile > @@ -3,7 +3,15 @@ CFLAGS=-Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer > LXDIALOG := lxdialog/checklist.o lxdialog/inputbox.o lxdialog/menubox.o lxdialog/textbox.o lxdialog/util.o lxdialog/yesno.o > > conf: conf.o zconf.tab.o > -mconf: LDFLAGS = -Wl,--no-as-needed $(shell ./lxdialog/check-lxdialog.sh -ldflags $(CC)) > + > +RELEASE=$(shell lsb_release -si) I think we'll need to have this work for cases where lsb_release does not exist too. Since you're issue is with gcc 4.8.2 on ubuntu and since I know gcc 4.8.3 (opensuse) and gcc 4.9.1-15 (debian testing) works with the solution I provided I say we use the options I specified in the original patch as the default. If someone has a gcc older than or equal than gcc 4.8.2 but not on Ubuntu it'd be good to know if this issue is there as well as then we could just match this to the gcc version. Luis -- To unsubscribe from this list: send the line "unsubscribe backports" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
