On Tue, Oct 28, 2014 at 11:57 PM, Grumbach, Emmanuel <emmanuel.grumbach@xxxxxxxxx> wrote: >> >> On Tue, Oct 28, 2014 at 1:07 PM, Grumbach, Emmanuel >> <emmanuel.grumbach@xxxxxxxxx> wrote: >> >> >> >> On Tue, Oct 28, 2014 at 10:08 AM, Grumbach, Emmanuel >> >> <emmanuel.grumbach@xxxxxxxxx> wrote: >> >> > >> >> > I can't make menuconfig. Reverting this patch fixes it. >> >> >> >> There's no context provided here, gcc version, Linux distribution, >> >> etc. With some of that it would help. >> >> >> > >> > * Ubuntu 14.04 >> > * gcc -v >> > Using built-in specs. >> > COLLECT_GCC=/usr/bin/gcc >> > COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/4.8/lto-wrapper >> > Target: x86_64-linux-gnu >> > Configured with: ../src/configure -v --with-pkgversion='Ubuntu >> > 4.8.2-19ubuntu1' >> > --with-bugurl=file:///usr/share/doc/gcc-4.8/README.Bugs >> > --enable-languages=c,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr >> > --program-suffix=-4.8 --enable-shared --enable-linker-build-id >> > --libexecdir=/usr/lib --without-included-gettext >> > --enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.8 >> > --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu >> > --enable-libstdcxx-debug --enable-libstdcxx-time=yes >> > --enable-gnu-unique-object --disable-libmudflap --enable-plugin >> > --with-system-zlib --disable-browser-plugin --enable-java-awt=gtk >> > --enable-gtk-cairo >> > --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-4.8-amd64/jre >> > --enable-java-home >> > --with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-4.8-amd64 >> > --with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-4.8-amd64 >> > --with-arch-directory=amd64 >> > --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --enable-objc-gc >> > --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 >> > --with-multilib-list=m32,m64,mx32 --with-tune=generic >> > --enable-checking=release --build=x86_64-linux-gnu >> > --host=x86_64-linux-gnu --target=x86_64-linux-gnu Thread model: posix >> > gcc version 4.8.2 (Ubuntu 4.8.2-19ubuntu1) >> > >> > I am compiling against 3.16.1 >> > >> > Please let me know what else you want to know. >> >> The kernel solution to this uses an internal kernel variables to prefix flags for >> the linker, the solution I provided is supposed to do that but perhaps for >> some older linker it doesn't do that, I'm afraid that since we don't have the >> internal variable solution and that porting it would be hard (probably >> pointless) we'll have to work around this then as mimicking that won't be >> easy >> >> Can you try a solution on the backport/kconf/Makefile that see's if >> lsb_release is available and use that for older releases of Ubuntu? >> I'd try it but since you have the system I figure it'd be easier. >> > > This works for me: > > > diff --git a/backport/kconf/Makefile b/backport/kconf/Makefile > index dfd793a..8398f35 100644 > --- a/backport/kconf/Makefile > +++ b/backport/kconf/Makefile > @@ -3,7 +3,15 @@ CFLAGS=-Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer > LXDIALOG := lxdialog/checklist.o lxdialog/inputbox.o lxdialog/menubox.o lxdialog/textbox.o lxdialog/util.o lxdialog/yesno.o > > conf: conf.o zconf.tab.o > -mconf: LDFLAGS = -Wl,--no-as-needed $(shell ./lxdialog/check-lxdialog.sh -ldflags $(CC)) > + > +RELEASE=$(shell lsb_release -si) > +ifeq ($(RELEASE), Ubuntu) > + AS_NEEDED=--no-as-needed > +else > + AS_NEEDED=--add-needed > +endif > +mconf: LDFLAGS = -Wl,$(AS_NEEDED) $(shell ./lxdialog/check-lxdialog.sh -ldflags $(CC)) > + > mconf: CFLAGS += -DCURSES_LOC="<ncurses.h>" -DLOCALE > mconf: mconf.o zconf.tab.o $(LXDIALOG) Thanks for doing this, any chance this can be reduced down to < version match? I'm in hope that this is only an issue with old releases otherwise we should look for another solution. Luis -- To unsubscribe from this list: send the line "unsubscribe backports" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
