On Fri, 2014-05-09 at 12:37 -0700, Luis R. Rodriguez wrote: > On Thu, May 8, 2014 at 11:23 PM, Johannes Berg > <johannes@xxxxxxxxxxxxxxxx> wrote: > > > > The spatch conversion (commit 05d44557c6a83b4ecb935cb6306f62, > > "backports: transform group attribute backport to SmPL form") > > added an #ifdef that shouldn't be there - remove it. > > When re-doing this I did make this change on purpose as I could not > see how those were being defined for newer kernels, where is that? Arguably you just got the ifdefs wrong - it should be < not >=. However, the backport header file backport/backport-include/linux/device.h #undef's ATTRIBUTE_GROUPS and redefines it so that we can call the init function unconditionally. That's not strictly needed, but if we wanted to do it differently we'd need to rewrite the header file a bit. I originally did it this way to make the patch smaller, now that it's an spatch it doesn't matter much. johannes -- To unsubscribe from this list: send the line "unsubscribe backports" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
