On Wed, 2014-02-12 at 18:44 -0500, Ido Yariv wrote: > > > +#include_next <linux/device.h> > > > > That include_next is probably wrong, if you really need linux/device.h > > you shouldn't use #include_next but a regular #include. > > My intention was to load the kernel's device.h and not backport's. The > reason was that some definitions which are now part of acpi.h were > defined by device.h in the past. > > That being said, backport's device.h includes the kernel's version, so > this can be modified to a regular #include and work just as well. Right. I just think it seems odd in terms of backport header style, and occasionally some backport header depends on some other backported thing, so a plain #include is the right thing at least in those cases. Not to mention that #include_next is a gcc-specific hack :) johannes -- To unsubscribe from this list: send the line "unsubscribe backports" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html