Re: [PATCH 2/2] backports: add support for testing only a single Coccinelle SmPL patch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 19 Jan 2014, Johannes Berg wrote:

> On Sun, 2014-01-19 at 18:07 +0100, Hauke Mehrtens wrote:
> 
> > > $ time ./gentree.py --clean --verbose --test-cocci \
> > > 	patches/collateral-evolutions/network/11-dev-pm-ops.cocci \
> > > 	/home/mcgrof/linux-next/ \
> > > 	/home/mcgrof/build/backports-20131206
> 
> I'm not really convinced that adding profile options for spatch is a
> good thing in gentree anyway. It's complicated enough as is, and running
> the spatch manually isn't all that difficult. If you use the --gitdebug
> option to gentree, you could even roll back to just before the patch was
> applied before running it manually.
> 
> Now, I don't want to control what goes into backports, but this way I
> might end up having to rewrite it again ;-)

I'm not sure to understand the issue.  Spatch has a --profile option, but 
I don't see it in the above code.  From my point of view, it could be nice 
if people are somehow encouraged to use that option from time to time, 
because it increases the chance that they will report back on performance 
problems.  But there is no need for it to bein the default execution path.

julia
--
To unsubscribe from this list: send the line "unsubscribe backports" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux