On Fri, Aug 16, 2013 at 12:45:12PM +0200, Hauke Mehrtens wrote:
> Hi Luis,
>
> The empty implementations of owner_running() and mutex_spin_on_owner()
> in backport/compat/kernel/ww_mutex.c should return something (one an in,
> one an bool), but they don't. That causes a compile warning about a
> missing return statement with kernel 3.9. I do not understand that code,
> could you please have a look into that.
Sure here's the fix, I'll submit. Thanks for reporting this.
Luis
diff --git a/backport/compat/kernel/ww_mutex.c b/backport/compat/kernel/ww_mutex.c
index 257c2a4..204ac8f 100644
--- a/backport/compat/kernel/ww_mutex.c
+++ b/backport/compat/kernel/ww_mutex.c
@@ -206,10 +206,12 @@ static void mspin_unlock(struct mspin_node **lock, struct mspin_node *node)
static inline bool owner_running(struct mutex *lock, struct task_struct *owner)
{
+ return false;
}
int mutex_spin_on_owner(struct mutex *lock, struct task_struct *owner)
{
+ return 1;
}
static inline int mutex_can_spin_on_owner(struct mutex *lock)
Attachment:
signature.asc
Description: Digital signature
