On Fri, Aug 16, 2013 at 12:38:39PM +0200, Hauke Mehrtens wrote: > I just compile tested cw1200 against many kernel versions and I always > get an error of a missing symbol for kernel <= 3.9: > > WARNING: "get_random_int" > [/pub/mem/hauke/devel/tmp/.tmp.ckmake/3.4.56/drivers/net/wireless/cw1200/cw1200_core.ko] > undefined! Argh, it wasn't an exported symbol in older kernels. (How did this ever work for me on my 3.4 testbed?) Hmm. Rather than patching cw1200 to use get_random_bytes(), would it make more sense to add a backported version of this to compat-3.8 instead? > I deactivate compiling against older kernels than 3.6.39 because that > caused some other problems like starting with 3.6.37 and missing > hw_features in 2.6.38: > > drivers/net/wireless/cw1200/bh.c: In function ‘cw1200_register_bh’: > drivers/net/wireless/cw1200/bh.c:62:72: error: ‘WQ_CPU_INTENSIVE’ > undeclared (first use in this function) > drivers/net/wireless/cw1200/bh.c:62:72: note: each undeclared > identifier is reported only once for each function it appears in > make[7]: *** [/drivers/net/wireless/cw1200/bh.o] Error 1 IIRC this was actually defined in 2.6.36. I have another patch (stripped via the mainlining effort) that implements this functionality via kthreads for <=2.6.35 kernels. (Given that the new workqueue semantics were backported, I'd hoped to retire this patch...) I'll go through the 'ckmake' process, and post any necessary patches to get cw1200 to cleanly build at least as far back as 2.6.35. Cheers, - Solomon -- Solomon Peachy pizza at shaftnet dot org Delray Beach, FL ^^ (email/xmpp) ^^ Quidquid latine dictum sit, altum viditur.
Attachment:
pgpBu7oTejL9K.pgp
Description: PGP signature
