On Tue, 2013-07-16 at 21:35 +0200, Hauke Mehrtens wrote:
> > -#ifndef alloc_ordered_workqueue
> > -#define alloc_ordered_workqueue(name, flags) create_singlethread_workqueue(name)
> > +#if LINUX_VERSION_CODE < KERNEL_VERSION(3,3,0)
> > +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,36)
>
> Why not do a check for #ifndef WQ_UNBOUND that way we do not get that
> many problems when someone tries a kernel that already backported this.
It's an enum, so that won't work.
> The #undef destroy_workqueue in compat-3.3.c does not look nice to me.
>
> What about this and then call orig_destroy_workqueue(wq)?
>
> static inline void orig_destroy_workqueue(struct workqueue_struct *wq)
> {
> destroy_workqueue(wq);
> }
> #define destroy_workqueue(wq) backport_destroy_workqueue(wq)
Why? I don't see a reason to expose this to users of the API.
johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
