Re: [PATCH 8/9] lib/bpkup.py: add or own kernel uploader helper lib

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2013-05-22 at 04:34 -0700, Luis R. Rodriguez wrote:

> +def put(tar_bz2=None, signed_tar=None, path=None):
> +    cmd = ['kup', 'put', tar_bz2, signed_tar, path]

Without even looking, the =None here can't be right since if you don't
pass any of these args, it'll just get completely confused and probably
crash trying to pass None as an argument? Seems you should just require
all these args.

johannes

--
To unsubscribe from this list: send the line "unsubscribe backports" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux