Re: [PATCH 01/12] backports: make compat module use subsys_initcall()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > I applied all but this one, it caused a compiler warning that seemed
> > important (missing an include?)
> >
> > /tmp/i/compat/main.c:83:1: warning: data definition has no type or
> > storage class [enabled by default]
> > /tmp/i/compat/main.c:83:1: warning: type defaults to ‘int’ in
> > declaration of ‘__exitcall’ [-Wimplicit-int]
> > /tmp/i/compat/main.c:83:1: warning: parameter names (without types) in
> > function declaration [enabled by default]
> > /tmp/i/compat/main.c:76:123: warning: ‘backport_exit’ defined but not
> > used [-Wunused-function]
> 
> Sorry can you try this?

It can't work, because the definition of __exitcall is under "#ifndef
MODULE" in include/init.h. But since module_exit() is defined to be
__exitcall (in case the module is built-in) why not just keep
module_exit()? And vice versa, subsys_init() is defined to be
module_init() in case of being built modular.

johannes

--
To unsubscribe from this list: send the line "unsubscribe backports" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux