Re: [PATCH 4/9] compat: backport EPROBE_DEFER value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Apr 7, 2013 at 10:22 AM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> On Sat, 2013-04-06 at 19:21 -0700, Luis R. Rodriguez wrote:
>> From: "Luis R. Rodriguez" <mcgrof@xxxxxxxxxxxxxxxx>
>>
>> Grant added the ability to the driver core to return
>> EPROBE_DEFER at device driver probe time and for that to
>> trigger a later deferred probe through a workqueue. It
>> seems we could in theory backport this functionality but
>> that requires quite a bit of work. For now just pass on
>> the EPROBE_DEFER definition safely and for older kernels
>> than 3.4 the EPROBE_DEFER would be treated as a regular
>> probe error.
>
>> +#define EPROBE_DEFER   517     /* Driver requests probe retry */
>
> I'm not convinced this is useful, particularly not with that error
> number?
>
> If a driver returns -EPROBE_DEFER it will not work correctly, so why not
> just require it to be disabled (via the dependencies list) for kernels
> before 3.4?
>
> Also, if you return -517 userspace might get somewhat confused?

Sure.

  Luis
--
To unsubscribe from this list: send the line "unsubscribe backports" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux