On 02/03/2013 08:19 PM, Ozan Çağlayan wrote: >> >> Why are you removing the ifeq ($(BT),) here? > > Well I didn't get what it does. (It seems to switch on/off bluetooth > but not in an intuitive way) Also it was always set to True without > user's intervention so I removed it to provoke a discussion about its > functionality :p I do not get it neither. ;-) Could you remove it in a separate patch., in the long term it be nice to deactivate it like gpu and network independently from the other network stuff. >> I think it is better to add all (gpu and network) when nothing specific >> was given, this way the script does the same when the same parameters >> are given than it did before. > > Well yes you are right but then we have to change the parameter logic > to support disabling subsystems, e.g. > > admin-update.sh --disable-network. Isn't there a away to treat everything as selected if nothing is given and if something was given just build that particular subsystem. Hmm, the longer I think about it this also does not sound very nice. I think your first approach is better, just add the selected subsystems But a help page should be displayed when nothing was given explaining what to do. Hauke -- To unsubscribe from this list: send the line "unsubscribe backports" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
