Re: [PATCH 5/5] compat-drivers: do not apply patches in natural sort order

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/30/2012 08:58 AM, Ozan Çağlayan wrote:
> On Thu, Nov 29, 2012 at 5:24 PM, Hauke Mehrtens <hauke@xxxxxxxxxx> wrote:
>> Without this patch the patches are applied in the natural sort order of
>> numbers, which caused this order for patches/network/:
>> patches/network/0001-netdev_ops.patch
>> patches/network/02-ksize.patch
>> patches/network/0002-net-misc.patch
>> patches/network/0003-netdev-needed_headroom_tailroom.patch
>> patches/network/03-rfkill.patch
>> patches/network/04-netns.patch
>> patches/network/0004-wext-namespace.patch
>> patches/network/0005-netlink-portid.patch
>> patches/network/05-usb.patch
> 
> Actually it was me who changed/broke this and I really can't decide
> now which one is more intuitive.
> 
> commit 46a5aef05b92a2162150326f426bebe3541d6e8c
> Author: Ozan Çağlayan <ozancag@xxxxxxxxx>
> Date:   Fri Jun 22 16:30:54 2012 +0300
> 
>     compat-wireless: Naturally sort patch prefixes
> 
>     Use ls -v to get a naturally sorted list of patches like:
> 
>     patches/00-vga_switcheroo_client_ops.patch
>     patches/01-dma_buf_ops-addition.patch
>     patches/02-revert-vm_mmap.patch
>     patches/98-pr_fmt.patch
>     patches/99-change-makefile.patch
>     patches/9999-FIXME-dont-build-i915-for-i2c-problems.patch
> 
>     instead of:
> 
>     patches/00-vga_switcheroo_client_ops.patch
>     patches/01-dma_buf_ops-addition.patch
>     patches/02-revert-vm_mmap.patch
>     patches/98-pr_fmt.patch
>     patches/9999-FIXME-dont-build-i915-for-i2c-problems.patch
>     patches/99-change-makefile.patch
> 
>     Signed-off-by: Ozan Çağlayan <ozancag@xxxxxxxxx>
>     Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxxxxxxx>

Hi Ozan,

I missed looking which commit introduced this, I thought it was there
for ever. With ls -v the prefixes 0005 and 05 are the same and the
ordering is done by the following characters, this is the reason
04-netns.patch is in front of 0004-wext-namespace.patch, but
0005-netlink-portid.patch is in front of 05-usb.patch.

For your use case adding the -v is a good option, but as we now have
some patches with four digits and some with two digits I think the
version without the -v is the better option, or we rename the patches to
one common pattern.

Hauke
--
To unsubscribe from this list: send the line "unsubscribe backports" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux