Re: [agl-dev-community] new AGL service repo #help

["Jan Simon Moeller" <jsmoeller@xxxxxxxxxxxxxxxxxxx>]

Hi !
See my comments inline to explain what happened:



On Wed, May 6, 2020 at 6:33 PM Marat <marat.sabitov@xxxxxxxx> wrote:
>
> Hi, thanks.
> My attempts:
>
> %git push agl HEAD:refs/for/master
> fatal: 'agl' does not appear to be a git repository
> fatal: Could not read from remote repository.
> Please make sure you have the correct access rights

git push <git remote name>  <LOCAL>:<DESTINATION>

Thus 'agl' is the "git remote" name.
Usually this is 'origin' if you clone directly.
It is 'agl' if you use the repo tool to clone all git repos (it uses the name in the manifest).
It is 'gerrit' if you've setup 'git review'  (e.g. call 'git review -s' once) .

> and the repository exists.
> %git push gerrit HEAD:refs/for/master
> Counting objects: 4, done.
> Delta compression using up to 2 threads.
> Compressing objects: 100% (4/4), done.
> Writing objects: 100% (4/4), 578 bytes | 0 bytes/s, done
> Total 4 (delta 3), reused 0 (delta 0)
> remote: Resolving deltas: 100% (3/3)
> remote: Processing changes: refs: 1, done    
> To ssh://maratsabitov@xxxxxxxxxxxxxxxxxxxxxxxxxx:29418/AGL/AGL-repo
>  ! [remote rejected] HEAD -> refs/for/master (commit 9b293bd: not Signed-off-by author/committer/uploader in message footer)
> error: failed to push some refs to 'ssh://maratsabitov@xxxxxxxxxxxxxxxxxxxxxxxxxx:29418/AGL/AGL-repo'

We require the Signed-off-by. 

Maybe the the commit mess was empty and the signed-off-by the first line.

Please see https://chris.beams.io/posts/git-commit/  for the commit messages and

always add the "Bug-AGL: SPEC-????" link back to jira.

> I've checked - the commit was signed-off, anyway:
> %git commit --amend --signoff
> [meta-iot-cloud 544e07d] Signed-off-by: maratsabitov <marat.sabitov@xxxxxxxx> Change-Id: Iea57a02a7ce84d5d87a2669a2eba2a37d99cf8d1
>  Date: Sun May 3 11:30:16 2020 +0300
>  2 files changed, 6 insertions(+)
>
> And again:
> %git push gerrit HEAD:refs/for/master
> Counting objects: 4, done.
> Delta compression using up to 2 threads.
> Compressing objects: 100% (4/4), done.
> Writing objects: 100% (4/4), 610 bytes | 0 bytes/s, done.
> Total 4 (delta 3), reused 0 (delta 0)
> remote: Resolving deltas: 100% (3/3)
> remote: Processing changes: refs: 1, new: 1, done    
> remote: commit 544e07d: warning: subject >50 characters; use shorter first paragraph
> remote:
> remote: SUCCESS
> remote:
> remote:   https://gerrit.automotivelinux.org/gerrit/c/AGL/AGL-repo/+/24477 Signed-off-by: maratsabitov <marat.sabitov@xxxxxxxx> Change-Id: Iea57a02a7ce8... [NEW]
> remote:
> To ssh://maratsabitov@xxxxxxxxxxxxxxxxxxxxxxxxxx:29418/AGL/AGL-repo
>  * [new branch]      HEAD -> refs/for/master

With the signoff added by --amend the upload works.

Check the version of 'git review --version' is >= 2.18 .

It is also available using pip: e.g. pip3 install git-review .

Best,

Jan-Simon

> Marat

_._,_._,_

---

Links:

You receive all messages sent to this group.

View/Reply Online (#8328) | Reply To Group | Reply To Sender | Mute This Topic | New Topic
Mute #help
Your Subscription | Contact Group Owner | Unsubscribe [list-automotive-discussions82@xxxxxxxxxxx]

_._,_._,_