Hi Paul, On Wed, 20 Mar 2024 08:51:30 +0100, Paul Menzel wrote: ... > > /usr/include/ldap.h:2155:25: note: expected 'struct berval **' but > > argument is of type 'struct berval *' > > 2155 | ldap_parse_page_control LDAP_P(( > > I wouldn’t wrap the lines of the pasted parts, and use a more specific > commit message summary instead of just *fix … check*. Maybe: > > ldap_parse_page_control(): Use correct type for @cookie I'm fine with it either way, but I think the commit summary should indicate that it's the config-time ldap_parse_page_control() call that's problematic, not the modules/lookup_ldap.c invocation. @Ian: feel free to update the commit message as you see fit. ... > Reviewed-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx> Thanks for the review! David
