On 20/3/24 08:59, David Disseldorp wrote:
The final @cookie parameter should be a struct berval ** type. The check currently fails when -Werror=incompatible-pointer-types is set: conftest.c: In function 'main': conftest.c:54:47: error: passing argument 4 of 'ldap_parse_page_control' from incompatible pointer type [-Werror=incompatible-pointer-types] 54 | ret = ldap_parse_page_control(ld,clp,ct,c); | ^ | | | struct berval * In file included from /usr/include/lber_types.h:24, from /usr/include/lber.h:29, from /usr/include/ldap.h:30, from conftest.c:45: /usr/include/ldap.h:2155:25: note: expected 'struct berval **' but argument is of type 'struct berval *' 2155 | ldap_parse_page_control LDAP_P(( Signed-off-by: David Disseldorp <ddiss@xxxxxxx> --- aclocal.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aclocal.m4 b/aclocal.m4 index 1046d72..fa18eb1 100644 --- a/aclocal.m4 +++ b/aclocal.m4 @@ -424,7 +424,7 @@ AC_LINK_IFELSE( #include <ldap.h> ]], [[ LDAP *ld; ber_int_t *ct; - struct berval *c; + struct berval **c; int ret; LDAPControl **clp; ret = ldap_parse_page_control(ld,clp,ct,c); ]])],
Thanks David, looks ok to me, will have a closer look and (I expect) will apply it.
Ian