On Fri, 13 May 2022 10:16:40 +0800 Ian Kent <raven@xxxxxxxxxx> wrote: > On Thu, 2022-05-12 at 16:41 -0700, Clayton Craft wrote: > > Fixes a segfault when running the automount daemon with -v, where > > log.c:prepare_attempt_prefix calls pthread_getspecific when no > > key_thread_attempt_id exists. > > Could you have a look at commit ab9570be7ee7 and adjust this patch > as needed if it is needed please. Ya I hit the segfault on the latest master, so that commit is included: $ git lg|grep ab9570 * ab9570b - autofs-5.1.8 - avoid calling pthread_getspecific() with NULL key_thread_attempt_id (8 days ago) <Ian Kent> $ CFLAGS="-ggdb $CFLAGS" make -j12 >/dev/null $ doas gdb --args daemon/automount -v GNU gdb (GDB) 11.2 Reading symbols from daemon/automount... (No debugging symbols found in daemon/automount) (gdb) r Starting program: /home/clayton/src/autofs/daemon/automount -v Program received signal SIGSEGV, Segmentation fault. 0x00007ffff7fba96e in __pthread_getspecific (k=0) at src/thread/pthread_getspecific.c:7 7 src/thread/pthread_getspecific.c: No such file or directory. (gdb) bt #0 0x00007ffff7fba96e in __pthread_getspecific (k=0) at src/thread/pthread_getspecific.c:7 #1 0x00007ffff7f4cf9c in ?? () from /usr/lib/libautofs.so #2 0x00007ffff7f4d836 in logmsg () from /usr/lib/libautofs.so #3 0x000055555556c851 in open_fopen_r () #4 0x00007ffff7f51fe9 in defaults_read_config () from /usr/lib/libautofs.so #5 0x0000555555562cc8 in main () (gdb) f 0 #0 0x00007ffff7fba96e in __pthread_getspecific (k=0) at src/thread/pthread_getspecific.c:7 7 return self->tsd[k];
Attachment:
signature.asc
Description: PGP signature
