Re: [PATCH] autofs: add pid/comm to debug on autofs_notify_daemon

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ian, Paul

  Thanks for your suggestions. I'll send a new version addressing your
comments. I'll get rid of pid logging as in the end
  it does not add much value in this context. Command name can be more
useful for troubleshooting purposes.

rgds
roberto

On Mon, Jun 8, 2020 at 12:55 PM Paul Menzel <pmenzel@xxxxxxxxxxxxx> wrote:
>
> Dear Roberto,
>
>
> Thank you for the patch.
>
>
> Am 08.06.20 um 12:10 schrieb Roberto Bergantinos Corpas:
> >    This can be useful for troubleshooting purposes and this information
> >    is not directly avalaible to userland
>
> s/avalaible/available/
>
> It looks like you copied this from `git show`, which adds four trailing
> spaces in front of the commit message. Could you please remove those,
> should you resubmit? In the future, I recommend to use `git
> format-patch` and `git send-email`.
>
> Maybe, also add an example output of the new debug message.
>
> > Signed-off-by: Roberto Bergantinos Corpas <rbergant@xxxxxxxxxx>
> > ---
> >   fs/autofs/waitq.c | 5 +++--
> >   1 file changed, 3 insertions(+), 2 deletions(-)
>
>
> Kind regards,
>
> Paul
>




[Index of Archives]     [Linux Filesystem Development]     [Linux Ext4]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux