Old patch Ubuntu has been carrying since 2010

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

I'm updating the autofs version in Ubuntu from 5.1.2 to 5.1.5, and as
part of that process was looking over the patches we are carrying. I
found this one:
Author: Joel Ebel <jbebel@xxxxxxxxxx>
Bug-Ubuntu: https://launchpad.net/bugs/591100
Description: Increase group buffer size geometrically rather than
linearly when its found to be small.
.
This prevents package to eat the cpu if you have large groups.

--- a/lib/mounts.c
+++ b/lib/mounts.c
@@ -1245,7 +1245,7 @@
        status = getgrgid_r(gid, pgr, gr_tmp, tmplen, ppgr);
        if (status != ERANGE)
            break;
-       tmplen += grplen;
+       tmplen *= 2;
    }

    if (status || !pgr) {

That came from https://bugs.launchpad.net/ubuntu/+source/autofs5/+bug/591100,
and the intention is to speed up the scenario where a user belongs to
thousands of groups. grplen is 1024, and looping over getgrgid_r()
hundreds of times took a while of high CPU usage.

The patch doesn't apply cleanly anymore, but the tmplen+=grplen code
is still there. Would upstream be interested in adopting this change,
or something like it?

Cheers



[Index of Archives]     [Linux Filesystem Development]     [Linux Ext4]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux