Re: [PATCH v2] use pkg-config to search for libtirpc to fix cross-compilation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,
Ian Kent wrote,

> On Wed, 2017-06-28 at 12:29 +0200, Waldemar Brodkorb wrote:
> > When trying to cross-compile autofs for example with a buildsystem
> > like buildroot, the compilation fails in case the user wants to use
> > libtirpc library as RPC implementation. A hard coded include path
> > in aclocal.m4 is used. Other opensource software like rpcbind or
> > nfs-utils are suing autotools pkgconfig infrastructure to find
> > the libtirpc headers and to pass the correct linker flags.
> > 
> > Convert configure.in to use PKG_CHECK_MODULES and remove the
> > hand written autoconf macros from aclocal.m4.
> > 
> > To autoreconf the package you need pkg-config or pkgconf installed,
> > which provides the needed autoconf macros in pkg.m4. For an
> > non-automake project a full path to pkg.m4 is required.
> > 
> > This fixes cross-compilation of autofs and allows to use
> > alternative C libraries as uClibc-ng without internal RPC
> > support to be used in cross-compiling environments.
> > 
> > Signed-off-by: Waldemar Brodkorb <wbx@xxxxxxxxxxx>
> > ---
> > v1 -> v2:
> >   - add a better commit decription
> >   - add back missing TIRPC_WORKAROUND/WITH_LIBTIRPC defines
> >   - add back AC_CHECK_FUNCS([getrpcbyname getservbyname])
> > 
> > For autoheader/autoconf to generate configure/config.h you
> > need to have pkg-config installed on your development machine.
> > When the user does not have installed pkg-config later, he
> > can use autofs without libtirpc as before. 
> > Configure will fail when the user use --with-libtirpc and
> > pkg-config is not installed.
> 
> Thanks for this, I'll have a look through it.
> 
> > +# for pkg-config macros
> > +m4_include([/usr/share/aclocal/pkg.m4])
> > +

Yann (Buildroot developer) found out, that this include
can be avoided when the aclocal.m4 would be moved.
It seems autoconf does not search for macros in any
global directories, if this file is in the current
directory found.

Add this to configure.in: AC_CONFIG_MACRO_DIR([m4])
mkdir m4
git mv aclocal.m4 m4/autofs-macros.m4

Should I update the patch, according to this?

best regards
 Waldemar
--
To unsubscribe from this list: send the line "unsubscribe autofs" in



[Index of Archives]     [Linux Filesystem Development]     [Linux Ext4]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux