Sure, thank you for applying.
2016-07-07 15:09 GMT+09:00 Ian Kent <raven@xxxxxxxxxx>:
> On Mon, 2016-07-04 at 12:40 +0900, Tomohiro Kusumi wrote:
>> It's invalid if the given mode is neither dir nor link,
>> so warn on else case.
>
> I've added this too.
>
> But ....
>
>>
>> (v2 changed BUG_ON to WARN_ON)
>>
>> Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@xxxxxxxxx>
>> ---
>> fs/autofs4/inode.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/fs/autofs4/inode.c b/fs/autofs4/inode.c
>> index ad0ee93..89174ec 100644
>> --- a/fs/autofs4/inode.c
>> +++ b/fs/autofs4/inode.c
>> @@ -305,6 +305,7 @@ int autofs4_fill_super(struct super_block *s, void *data,
>> int silent)
>> if (autofs_type_trigger(sbi->type))
>> __managed_dentry_set_managed(root);
>>
>> + WARN_ON(!root_inode->i_fop || !root_inode->i_op);
>
> I'm dropping this.
>
> We know for a fact that this is a directory inode because above it was created
> with autofs4_get_inode(s, S_IFDIR | 0755) and here the operations are changed to
> those specific to the root inode.
>
>> root_inode->i_fop = &autofs4_root_operations;
>> root_inode->i_op = &autofs4_dir_inode_operations;
>>
>> @@ -368,7 +369,8 @@ struct inode *autofs4_get_inode(struct super_block *sb,
>> umode_t mode)
>> inode->i_fop = &autofs4_dir_operations;
>> } else if (S_ISLNK(mode)) {
>> inode->i_op = &autofs4_symlink_inode_operations;
>> - }
>> + } else
>> + WARN_ON(1);
>>
>> return inode;
>> }
--
To unsubscribe from this list: send the line "unsubscribe autofs" in
