Thank you.
Sure, feel free to commit it whenever you can, as it's just a cleanup.
2016-07-06 18:24 GMT+09:00 Ian Kent <raven@xxxxxxxxxx>:
> On Mon, 2016-07-04 at 18:32 +0900, Tomohiro Kusumi wrote:
>> Fix below compiler (gcc5) warning which isn't autoconf result dependent.
>> mounts.c:1779:7: warning: variable 'ret' set but not used [-Wunused-but-set
>> -variable]
>
> Indeed, I've been meaning to fix that but I like to have a return assigned even
> when it's not used so I can easily identify functions that return status when
> changes are needed, so I've left it alone.
>
> I'm adding this to my list of patches (as is).
>
> Unless there is a pressing need for this to be committed to the upstream
> repository it will be done the next time I push changes and I can't say when
> that will be.
>
>>
>> Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@xxxxxxxxx>
>> ---
>> lib/mounts.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/lib/mounts.c b/lib/mounts.c
>> index 1d1b4da..c67548e 100644
>> --- a/lib/mounts.c
>> +++ b/lib/mounts.c
>> @@ -1776,16 +1776,15 @@ static int remount_active_mount(struct autofs_point
>> *ap,
>> *ioctlfd = -1;
>> }
>> } else {
>> - int ret;
>> /*
>> * What can I do if we can't remount the existing
>> * mount(s) (possibly a partial failure), everything
>> * following will be broken?
>> */
>> if (type == t_indirect)
>> - ret = do_remount_indirect(ap, fd, path);
>> + do_remount_indirect(ap, fd, path);
>> else
>> - ret = do_remount_direct(ap, fd, path);
>> + do_remount_direct(ap, fd, path);
>> }
>>
>> debug(ap->logopt, "re-connected to mount %s", path);
--
To unsubscribe from this list: send the line "unsubscribe autofs" in
