Re: [PATCH] prevent autofs to try the wrong IP protocol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2016-01-19 at 01:45 +0100, Andreas Steinmetz wrote:
> On Mo, 2016-01-18 at 10:36 +0800, Ian Kent wrote:
> > On Sun, 2016-01-17 at 22:14 +0100, Andreas Steinmetz wrote:
> > > [please CC me on replies, I'm not subscribed]
> > > 
> > > If the user configures an IPv6 protocol for nfs, autofs tries
> > > IPv4
> > > too,
> > > and vice versa. The attached patch against autofs-5.1.1 prevents
> > > this.
> > > 
> > > The additional tries for the wrong IP protocol can be quite
> > > costly
> > > if
> > > e.g. an IPSec tunnel must be brought up.
> > 
> > Is this close to what your asking for (not even compile tested)?
> > 
> > I'm not certain this won't have any undesired side effects AFAICS
> > it
> > looks ok.
> > 
> > autofs-5.1.1 - fix ipv6 proto option handling
> > 
> 
> Well, I had to fix up your patch slightly to work, at least for my
> IPv6
> use cases. Except for the fact that there are now new version bits in
> use which do hopefully not cause any unwanted side effects it now
> seems
> ok to me. Modified patch of yours is attached.

OK, thanks, I'll have a look at the changes and integrate them.

I think all accesses to the bit fields are bitwise or should be anyway,
I'll have a look around to see if I can see any that could be a
problem.

> 
--
To unsubscribe from this list: send the line "unsubscribe autofs" in



[Index of Archives]     [Linux Filesystem Development]     [Linux Ext4]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux