On Mon, 2015-09-14 at 11:05 +0800, Ian Kent wrote: > On Sun, 2015-09-13 at 15:56 +0200, Cyril B. wrote: > > > > My solution was to add a --mode option to autofs, with the included > > patch. I'm not familiar with autofs's code or even Lex and Yacc, so my > > code is probably more of a proof of concept. It seems to work fine in my > > use case, though. > > If you want to contribute patches then post then in-line as text without > any additional change (eg. ensure the mailer doesn't split lines therby > corrupting the patch). > > I can't properly comment on the patch, even if I wanted too, because it > isn't in-line. > > Anyway, what about updating the man pages with your new option? > Should text modes be considered, perhaps octal modes are sufficient, and > should be all that's allowed, to keep the change as simple (generally a > good idea) ... And btw, I've been trying to ensure that all autofs patches have a problem description for quite a long time now, so we need that too. Generally describing what the change does isn't OK, a description of why it's needed is more important and usually negates the need to describe what the patch does. Recently I've started adding "Signed-off-by:" annotation too. Ian -- To unsubscribe from this list: send the line "unsubscribe autofs" in
