On Thu, 2014-11-06 at 07:02 +0800, Ian Kent wrote: > On Mon, 2014-11-03 at 06:33 -0800, Joe Perches wrote: > > > > That's fine. I left out the trailing semicolon/space. > > The pr_fmt could be something like: > > #define pr_fmt(fmt) KBUILD_MODNAME ":%d:%s: " fmt, current->pid, __func__ > > or add a "pid:" descriptor prefix if you like too: > > #define pr_fmt(fmt) KBUILD_MODNAME ":pid:%d:%s: " fmt, current->pid, __func__ > > > > > > it's better to use a consistent style for > > > > these logging functions ideally with terminating > > > > newlines so there isn't a mix of code with > > > > and without those newlines. That inconsistency > > > > leads to unintended defects. > > > > > > The idea here was to make the logging consistent throughout. > > > > Mine too. > > > > > I have become used of not using the new-line terminator in logging over > > > the years and tend to favour that myself. You recommend not doing that > > > probably from a kernel wide consistency perspective? Maybe that is > > > better ... > > > > Yes, kernel style consistency is the rationale. > > > > Over time, people come along and add messages > > while not reading the code very closely so using > > the kernel style with newlines can help avoid > > these trivial defects. > > I can see how not including the trailing newline in the macros is a good > thing and I'll forward a couple more patches to Andrew for this and fix > the inconsistencies. OK, great. > But idea of using pr_xxx() and pr_fmt() (actually that's too open to > name clashes so it would need to be named something like autofs_pr_fmt() > anyway) looks like it results in less readable code so I'd really prefer > not to do that. Using pr_info/pr_debug (or any other pr_<level>) is a generic mechanism in the kernel. Adding a #define pr_fmt is also generic thing that works with all the pr_<level> uses in a specific compilation unit. cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe autofs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
