On Thu, 2014-07-10 at 09:41 +1000, NeilBrown wrote: > The variable 'ino' already exists and already > has the correct value. The d_fsdata of a dentry > is never changed after the d_fsdata is instantiated, > so this new assignment cannot be necessary. > > It was introduced in > commit b5b801779d59165c4ecf1009009109545bd1f642 > autofs4: Add d_manage() dentry operation > > Signed-off-by: NeilBrown <neilb@xxxxxxx> Again, an obvious cleanup, thanks for that. Acked-by: Ian Kent <raven@xxxxxxxxxx> > --- > fs/autofs4/expire.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/autofs4/expire.c b/fs/autofs4/expire.c > index 394e90b02c5e..a7be57e39be7 100644 > --- a/fs/autofs4/expire.c > +++ b/fs/autofs4/expire.c > @@ -333,7 +333,6 @@ struct dentry *autofs4_expire_direct(struct super_block *sb, > if (ino->flags & AUTOFS_INF_PENDING) > goto out; > if (!autofs4_direct_busy(mnt, root, timeout, do_now)) { > - struct autofs_info *ino = autofs4_dentry_ino(root); > ino->flags |= AUTOFS_INF_EXPIRING; > init_completion(&ino->expire_complete); > spin_unlock(&sbi->fs_lock); > > -- To unsubscribe from this list: send the line "unsubscribe autofs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html