(...) >>> Hello Ian, >>> >>> Sorry to resurrect such an old thread. We're still carrying this patch >>> in our package and I'd like to get rid of it, preferably by getting it >>> accepted upstream :-) >>> >>> As described above, the core dump analysis really pointed to an >>> use after free condition when (&task->pending)->next == task. It's >>> unfortunate that we received such report only once and had no >>> specific info about the circumstances that could trigger the problem. >>> >>> In any case, moving free(task) to the end of the block should be >>> safe and is actually how it was done before commit 6273ab63c. Do >>> you think you can accept the patch as is? >> >> I didn't see a patch in the previous thread. >> Presumably you have a patch with a description you could post. >> >> TBH, I don't think it's worth perusing this further since the change >> looks safe enough I can just add it to my commit queue for the next time >> I commit changes. > > Sure! Please see the patch attached (for some reason Gmail is no > longer expanding tabs here). Hello Ian, Looks like this one was not included in the last commit round. Could you perhaps schedule it for the next one? Thanks, Leonardo -- To unsubscribe from this list: send the line "unsubscribe autofs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
