Re: [PATCH 2/2, 2nd attempt] samples/auto.smb: add logic to obtain credentials

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2013-09-06 at 11:40 +0200, Martin Wilck wrote:
> On 09/06/2013 11:26 AM, Ian Kent wrote:
> > On Fri, 2013-09-06 at 10:23 +0200, Martin Wilck wrote:
> >> On 09/06/2013 09:59 AM, Ian Kent wrote:
> >>
> >>>> -$SMBCLIENT -gNL $key 2>/dev/null| awk -v key="$key" -v opts="$opts" -F'|' -- '
> >>>> +creds=/etc/creds/$key
> >>>> +if [ -f "$creds" ]; then
> >>>> +    opts="$opts"',uid=$UID,gid=$GID,credentials='"$creds"
> >>>> +    smbopts="-A $creds"
> >>>> +else
> >>>> +    get_krb5_cache
> >>>> +    if [ -n "$cache" ]; then
> >>>> +        opts="$opts"',multiuser,cruid=$UID,sec=krb5i'
> >>>> +        smbopts="-k"
> >>>> +        export KRB5CCNAME=$cache 
> >>>> +    else
> >>>> +        opts="$opts"',guest'
> >>>
> >>> Why add guest?
> >>
> >> "guest" means "don't prompt for a password" which is what mount.cifs
> >> will attempt to do if no credentials are available already (e.g. via
> >> kerberos ticket). IMO that's what's needed for autofs, otherwise the
> >> mount attempt might hang waiting for password input.
> >>
> >>> Is that going to change the behavior of the existing script.
> >>
> >> "guest" mode was all the previous script could do, thus it seems to have
> >> been written with servers in mind that only offered guest access in the
> >> first place (und thus wouldn't prompt for a password, either).
> > 
> > From my POV auto.smb is an example program map that happens to get
> > installed. I don't think it was never meant to be sophisticated.
> 
> Sure. We might as well keep it as it is, or just provide the new one
> alongside the old one as another example.

Maybe, but, having looked more closely at it, it should still function
as it did previously so I'm inclined to add the patch.

> 
> > You are saying that adding guest doesn't change anything as it is the
> > default when no credentials are provided, correct?
> 
> That's right.
> 
> Martin
> 


--
To unsubscribe from this list: send the line "unsubscribe autofs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux Ext4]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux