On Tue, Aug 20, 2013 at 4:06 PM, Dennis Lan (dlan) <dennis.yxun@xxxxxxxxx> wrote: > On Tue, Aug 20, 2013 at 3:18 PM, Ian Kent <raven@xxxxxxxxxx> wrote: >> On Tue, 2013-08-20 at 12:34 +0800, Dennis Lan (dlan) wrote: >>> On Tue, Aug 20, 2013 at 11:44 AM, Ian Kent <raven@xxxxxxxxxx> wrote: >>> > On Tue, 2013-08-20 at 11:23 +0800, Ian Kent wrote: >>> >> On Mon, 2013-08-19 at 14:23 +0800, Lan Yixun (dlan) wrote: >>> >> > those patches are very trivial changes which only instroduce a new --with-systemdsystemunitdir option >>> >> > to better control where we should install system unit file to >>> >> > >>> >> > 1) seperate --with-systemd opiton, but been kept now for future use (but it's useless now) >>> >> > 2) add new option --with-systemdsystemunitdir to manage the path where unit file will be installed >>> >> > 3) --with-systemd and --with-systemdsystemunitdir are two seperate option, so unit can be installed even systemd support is not enabled. >>> >> > >>> >> > downstream discussion: https://bugs.gentoo.org/show_bug.cgi?id=479492 >>> >> > >>> >> > let me know whether this looks good to you.. >>> >> >>> >> Looks OK but I'll need to spend some time on it in case it conflicts >>> >> with downstream usage I already have. >>> > >>> > After a very quick initial look .... >>> > >>> > It appears that the change does two things. >>> > >>> > Defines WITH_SYSTEMD for subsequent use, although applications usually >>> > don't need to know if they are being managed by systemd. Do you know of >>> > any cases where that is important? >>> > >>> No, no cases I know of, >>> So, I leave you to decide whether to keep it or not >> >> Yeah, but it may be needed to control whether the unit file is actuall >> installed. Seems a bit round of a round about way to do this. >> > This seems against @systemd gentoo's suggestion (to install the unit > file unconditionally) > because it will be controlled under --with-systemd option > >>> >>> > And changes the original --with-systemd configure option to >>> > --with-systemdsystemunitdir adding the ability to specify a unit >>> > directory explicitly. >>> > >>> > Why is it worthwhile changing the configure option as part of this >>> > change? >>> > >>> > Ian >>> > >>> > >>> As talked with gentoo @systemd team, it's conventional to use >>> "--with-systemdsystemunitdir"[1] >>> and I think it's would be slight better/explicitly to pass the unit >>> directory via --with-systemdsystemunitdir=/my/unit/dir/?current logic >>> is "--with-systemd systemddir=/my/unit/dir/" >> >> It amounts to changing the configure option name and adding the ability >> to specify a directory. > Yes, It is > >> >> The discussion implies there's precedent for using this name, do your >> the systemd guys know of other packages that use this naming, what are >> they? > I will let gentoo @systemd team answer this.. > >> >> I get the request to be able to specify a directory, that's cool. >> >> The other thing I think I saw in the discussion was unconditional >> installation of the unit file. > yes > >>The unit file has substitution done on it >> unconditionally but the macro paths are only set if the configure option >> is given. So there's no way to say, look for the systemd directories or >> use the given path but don't actually install the unit file. The actual > Yes, this is the original logic, but if you following my proposal patch, > we can install NO unit file by passing --with-systemdsystemunitdir=no > or --without-systemdsystemunitdir > for the original code, we need to pass --without-systemd, but it's a > little bit confusing (the disable install unit file) > >> unconditional install is probably best done in the ebuild, simple >> enough. > yes, this would be another approach, but if goes this way, then > wouldn't I proposal this patch.. > >> >> Ian >> >> >> >> > Hi Ian: > I don't have much knowledge about systemd, so let me CC gentoo @systemd team, > in case they have some inputs or my understanding is wrong/stupid.. > The discussions can be found here [1], the actual patches I proposal > can be found here [2],[3] > > Dennis Lan (dlan) > > > [1] http://thread.gmane.org/gmane.linux.kernel.autofs/6703 > [2] http://article.gmane.org/gmane.linux.kernel.autofs/6702 > [3] http://article.gmane.org/gmane.linux.kernel.autofs/6704 HI Ian: the answer about why we advocate --with-systemdsystemunitdir can be found here https://bugs.gentoo.org/show_bug.cgi?id=479492#c16 thanks Dennis Lan (dlan) -- To unsubscribe from this list: send the line "unsubscribe autofs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
