On Tue, Jul 23, 2013 at 6:42 PM, Ian Kent <raven@xxxxxxxxxx> wrote: > On Tue, 2013-07-23 at 18:37 +0800, Dennis Lan (dlan) wrote: >> On Tue, Jul 23, 2013 at 6:17 PM, Ian Kent <raven@xxxxxxxxxx> wrote: >> > On Mon, 2013-07-22 at 22:59 +0800, Lan Yixun (dlan) wrote: >> >> From: "Lan Yixun (dlan)" <dennis.yxun@xxxxxxxxx> >> >> >> >> make "libxml/tree.h" controlled by WITH_SASL, also move it beind line of >> >> #include "automount.h", since WITH_SASL is defined in config.h which is >> >> included by automout.h >> > >> > Same again, WITH_LDAP defined and WITH_SASL not. >> > I agree there appears to be a problem but not sure what to do about it. >> > >> >> >> >> --- >> >> Gentoo Bugs: >> >> https://bugs.gentoo.org/show_bug.cgi?id=468606 >> >> >> >> gcc -shared -O2 -pipe -march=core2 -D_REENTRANT -D_FILE_OFFSET_BITS=64 -D_REENTRANT >> >> -D_FILE_OFFSET_BITS= >> >> 64 -I../include -I../lib -fPIC -D_GNU_SOURCE -DAUTOFS_LIB_DIR=\"/usr/lib64/autofs\" >> >> -DAUTOFS_MAP_DIR=\"/e >> >> tc/autofs\" -DLDAP_DEPRECATED=1 -o lookup_ldap.so \ >> >> lookup_ldap.c dclist.o base64.o \ >> >> ../lib/autofs.a -lldap -llber -lresolv >> >> : lookup_yp.so >> >> lookup_ldap.c:31:25: fatal error: libxml/tree.h: No such file or directory >> >> #include <libxml/tree.h> >> >> ^ >> >> compilation terminated. >> >> >> >> Signed-off-by: Lan Yixun (dlan) <dennis.yxun@xxxxxxxxx> >> >> --- >> >> modules/lookup_ldap.c | 5 ++++- >> >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> >> >> diff --git a/modules/lookup_ldap.c b/modules/lookup_ldap.c >> >> index b8970a6..fad558d 100644 >> >> --- a/modules/lookup_ldap.c >> >> +++ b/modules/lookup_ldap.c >> >> @@ -28,7 +28,6 @@ >> >> #include <arpa/nameser.h> >> >> #include <resolv.h> >> >> #include <lber.h> >> >> -#include <libxml/tree.h> >> >> >> >> #define MODULE_LOOKUP >> >> #include "automount.h" >> >> @@ -36,6 +35,10 @@ >> >> #include "lookup_ldap.h" >> >> #include "base64.h" >> >> >> >> +#ifdef WITH_SASL >> >> +#include <libxml/tree.h> >> >> +#endif >> >> + >> >> #define MAPFMT_DEFAULT "sun" >> >> >> >> #define MODPREFIX "lookup(ldap): " >> > >> > >> HI Ian: >> I haven't dig too much into the code. >> As far as I know (could be wrong).. LDAP SASL auth needs libxml? >> >> quote from configure.in (line 170) >> >> # LDAP SASL auth needs libxml and Kerberos >> AF_CHECK_LIBXML() >> AF_CHECK_KRB5() >> >> so libxml could be controlled by SASL, but not LDAP, right? >> (Btw, SASL require LDAP enabled) > > That's what occurred to me but, after a quick look, I'm thinking the xml > config still needs to be read. That's why I agree there's a problem that > needs fixing. > > I'll have to look at it along with that old Gentoo ldap patch I want to > commit. > >> Hi Ian: Good, if you have any progress, let me know ;_) Thanks >> Dennis >> -- >> To unsubscribe from this list: send the line "unsubscribe autofs" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe autofs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
