On Tue, Jul 23, 2013 at 6:10 PM, Ian Kent <raven@xxxxxxxxxx> wrote: > On Tue, 2013-07-23 at 17:50 +0800, Ian Kent wrote: >> On Mon, 2013-07-22 at 22:59 +0800, Lan Yixun (dlan) wrote: >> > From: "Lan Yixun (dlan)" <dennis.yxun@xxxxxxxxx> >> > >> > autofs will create symbol link mandatory no matter ldap support >> > is enabled or not. so, without this patch, lookup_ldaps.so will become >> > a dead link. >> >> I have added this to my patch queue. >> It will be committed next time I push patches to the repo. > > On second thoughts, what if WITH_LDAP is defined and WITH_SASL is not? > HI Ian: current logic is: if SASL is not enabled, then the symbol lookup_ldaps.so (which link to lookup_ldap.so) will not be created. what are you suggesting here? should symbol of lookup_ldaps.so be controlled by LDAP ? Thanks Dennis >> Thanks >> >> > >> > --- >> > Upstream Discussion: >> > http://thread.gmane.org/gmane.linux.kernel.autofs/5371 >> > >> > Signed-off-by: Lan Yixun (dlan) <dennis.yxun@xxxxxxxxx> >> > --- >> > modules/Makefile | 2 ++ >> > 1 file changed, 2 insertions(+) >> > >> > diff --git a/modules/Makefile b/modules/Makefile >> > index c5deb24..4bb1096 100644 >> > --- a/modules/Makefile >> > +++ b/modules/Makefile >> > @@ -74,7 +74,9 @@ install: all >> > -rm -f $(INSTALLROOT)$(autofslibdir)/mount_smbfs.so >> > ln -fs lookup_file.so $(INSTALLROOT)$(autofslibdir)/lookup_files.so >> > ln -fs lookup_yp.so $(INSTALLROOT)$(autofslibdir)/lookup_nis.so >> > +ifeq ($(SASL), 1) >> > ln -fs lookup_ldap.so $(INSTALLROOT)$(autofslibdir)/lookup_ldaps.so >> > +endif >> > ln -fs mount_nfs.so $(INSTALLROOT)$(autofslibdir)/mount_nfs4.so >> > ifeq ($(EXT2FS), 1) >> > ifeq ($(EXT3FS), 1) >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe autofs" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe autofs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
