Re: [PATCH v4 04/12] auto-fs: rename d_count field of dentry to d_refcount

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 03, 2013 at 08:50:07PM -0700, Linus Torvalds wrote:
> On Wed, Jul 3, 2013 at 8:33 PM, Waiman Long <Waiman.Long@xxxxxx> wrote:
> > Because of the d_count name change made in dcache.h, all references
> > to d_count have to be changed to d_refcount.  There is no change in
> > logic and everything should just work.
> 
> These filesystem patches need to be just joined into the same patch
> that does the d_count -> d_refcount change.
> 
> Otherwise the kernel won't build in lots of configurations for some
> commits, which makes things like bisecting much more painful than it
> should be.
> 
> So we can't do piece-meal changes that break the build for parts of the tree.

Frankly, my preference here would be to add static inline unsigned d_count(...)
and convert the uses of ->d_count outside of fs/{dcache.c,namei.c} and
include/linux/dcache.c to it as the first commit.  All users outside those
are readers, so there's no point playing with macros in this case...
--
To unsubscribe from this list: send the line "unsubscribe autofs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux Ext4]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux