get_proximity() crashes on interfaces with no addresses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Since commit aa6f7793 [autofs-5.0.7 - fix ipv6 proximity calculation] uses getifaddrs however it crashes on interfaces with no addresses. Fix the NULL check to ignore interfaces with no addresses.

Should it also check for the IFF_UP flag?

Doug

diff -ur autofs-5.0.7.orig/modules/replicated.c autofs-5.0.7/modules/replicated.c
--- autofs-5.0.7.orig/modules/replicated.c	2013-05-10 04:48:32.000000000 -0400
+++ autofs-5.0.7/modules/replicated.c	2013-05-10 04:50:07.000000000 -0400
@@ -166,7 +166,7 @@
 	this = ifa;
 	while (this) {
 		if (this->ifa_flags & IFF_POINTOPOINT ||
-		    this->ifa_addr->sa_data == NULL) {
+		    this->ifa_addr == NULL) {
 			this = this->ifa_next;
 			continue;
 		}
@@ -203,7 +203,7 @@
 	this = ifa;
 	while (this) {
 		if (this->ifa_flags & IFF_POINTOPOINT ||
-		    this->ifa_addr->sa_data == NULL) {
+		    this->ifa_addr == NULL) {
 			this = this->ifa_next;
 			continue;
 		}

[Index of Archives]     [Linux Filesystem Development]     [Linux Ext4]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux