On 08.06.2012 11:24, Ian Kent wrote: > On Fri, 2012-06-08 at 11:06 +0400, Michael Tokarev wrote: >> Loading autofs module is #ifdef'ed in the source, so >> there is no need to check for /proc (which is only used >> to load module) or modprobe. Both modprobe and /proc >> are always in the fixed location so there's no need to >> check for these to start with. > > /proc is needed for the mounted file systems lists. > autofs won't work without it. Yes, but /proc/mounts is used unconditionally as _PROC_MOUNTS #define, and there's no need to check for /proc presence at compile time. You may check its presense at run time (during startup) and complain if /proc is not mounted. The point of this patch is to stop checking standard stuff at configure time which is pointless. Another issue is the wrong usage of configure checks and compile-time preprocessor constructs: there's AC_ERROR for this, the rigth way to go is to check somehing in configure and error out immediately if the ckeck is is not satisfied, instead of using #ifdef at compile time. But okay, the comment is a bit misleading - it used not only to check /proc/filesystems. Should I resend the patch with reworded comment? Thanks, /mjt -- To unsubscribe from this list: send the line "unsubscribe autofs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
