David Binderman <linuxdev.baldrick@xxxxxxxxx> writes: > Hello there, > > linux-4.7-rc2/drivers/net/wireless/ath/ath6kl/wmi.c:2547]: (style) > Redundant condition: If 'EXPR <= 7', the comparison 'EXPR < 8' is > always true. > > Source code is > > if (!((params->user_pri < 8) && > (params->user_pri <= 0x7) && > > This might be a possible cut'n'paste error. This should be recently fixed: https://git.kernel.org/cgit/linux/kernel/git/kvalo/ath.git/commit/?h=ath-next&id=93b4a09f0f3068e3190548393f39262e5295960e > Also in the same file > > [drivers/net/wireless/ath/ath6kl/wmi.c:1220]: (style) Variable 'rate' > is assigned a value that is never used. > [drivers/net/wireless/ath/ath6kl/wmi.c:1484]: (style) Variable > 'new_threshold' is assigned a value that is never used. > [drivers/net/wireless/ath/ath6kl/wmi.c:3521]: (style) Variable 'ret' > is assigned a value that is never used. I guess these are still valid. -- Kalle Valo _______________________________________________ ath6kl mailing list ath6kl@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/ath6kl
