Steve deRosier <derosier@xxxxxxxxx> writes: > On Sun, Apr 17, 2016 at 5:07 PM, Julian Calaby <julian.calaby@xxxxxxxxx> wrote: >> Hi Steve, >> >> This looks like it's using standard serial rates. Does it accept >> non-standard rates? If not, should this be checked before being passed >> to the hardware? >> > > It should use standard serial rates, and obviously I defaulted it to a > sensible one. However, there's nothing that prevents you from using > odd and arbitrary rates in the firmware and it should just suck it in > and use it. In other words, the firmware will happily try to set 9507 > baud if you tell it to. > > This is specifically for debugging and working with the firmware and > IMHO, if you are using this feature and feel a need to set it to > something weird, I think the user should be allowed to. If you know > enough to be able to shoot yourself in the foot with this, then you > should know enough of what you should or shouldn't do and should be > allowed to. It's a debugging tool only and I don't see any reason to > waste lines in the driver to validate this input. I think likewise, normal users shouldn't touch this setting at all. -- Kalle Valo _______________________________________________ ath6kl mailing list ath6kl@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/ath6kl
