Hi Steve, On Tue, Apr 19, 2016 at 4:12 AM, Steve deRosier <derosier@xxxxxxxxx> wrote: > Hi Julian, > > Thanks for looking at the patch. > > On Sun, Apr 17, 2016 at 5:07 PM, Julian Calaby <julian.calaby@xxxxxxxxx> wrote: >> Hi Steve, >> >> This looks like it's using standard serial rates. Does it accept >> non-standard rates? If not, should this be checked before being passed >> to the hardware? >> > > It should use standard serial rates, and obviously I defaulted it to a > sensible one. However, there's nothing that prevents you from using > odd and arbitrary rates in the firmware and it should just suck it in > and use it. In other words, the firmware will happily try to set 9507 > baud if you tell it to. > > This is specifically for debugging and working with the firmware and > IMHO, if you are using this feature and feel a need to set it to > something weird, I think the user should be allowed to. If you know > enough to be able to shoot yourself in the foot with this, then you > should know enough of what you should or shouldn't do and should be > allowed to. It's a debugging tool only and I don't see any reason to > waste lines in the driver to validate this input. I'm of the opinion that one should never underestimate the ability of people to attempt to shoot themselves in the foot. However this is only a debugging interface so you do make a good point. I guess I'm worried that some idiot is going to set it to 2 baud or 2 billion baud for some dumb reason then come complaining to us when their wireless card crashes or locks up or something. Maybe we can just sweep this all under the carpet by putting all the debug uart stuff behind some nice #ifdef. > That's my perspective on the issue, but I recognize other opinions may > differ. Or you may know of a specific chip where it does matter (the > 6003s and 6004s I'm using don't seem to care). If you or Kalle insist > on it, I'll be happy to add in some value checking for this parameter. > It just doesn't seem worth-while to me. Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/ _______________________________________________ ath6kl mailing list ath6kl@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/ath6kl
