Re: [PATCH 6/6] ath6kl: properly null terminate the firmware string

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> writes:

> The firmware version read from the firmware image is not null terminated and
> because of that there were few bytes of garbage after the firmware string:
>
> [10420.164632] ath6kl: ar6004 hw 3.0 usb fw 3.5.0.300-1^A api 4
>
> Add proper null termination to ath6kl_fetch_fw_apin() clean the firmware
> version string.
>
> Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxxxx>

This one introduces a new warning and I need to drop it:

drivers/net/wireless/ath/ath10k/debug.c:671:2: warning: right shift count >= width of type [enabled by default]
drivers/net/wireless/ath/ath6kl/init.c:999 ath6kl_fetch_fw_apin() error: buffer overflow 'ar->wiphy->fw_version' 32 <= 32
wmi.c:(.text+0xd96373): undefined reference to `ath10k_dbg_save_fw_dbg_buffer'

-- 
Kalle Valo

_______________________________________________
ath6kl mailing list
ath6kl@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/ath6kl




[Index of Archives]     [Linux Kernel]     [Linux Wireless]     [Linux Bluetooth]     [Linux WPAN]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]

  Powered by Linux