Hello,
I would like to propose a small patch for dmraid in order to
successfully build with GCC option -Werror=format-security [1].
AFAIK, this patch does not cause any change in behavior.
You can find an example of failed build at this URL [2].
This patch proposal is part of the Reproducible Builds initiative for
Arch Linux packages. [3]
If there is another way to propose patches for dmraid, please advise.
Regards,
Sébastien Duthil
[1] https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html
[2] https://tests.reproducible-builds.org/archlinux/core/dmraid/build1.log
[3] https://tests.reproducible-builds.org/archlinux/archlinux.html
diff --git a/lib/events/libdmraid-events-isw.c b/lib/events/libdmraid-events-isw.c
index c092762..d5efe22 100644
--- a/lib/events/libdmraid-events-isw.c
+++ b/lib/events/libdmraid-events-isw.c
@@ -824,13 +824,13 @@ static void _log_either(enum log_type log_type,
sz = _log_all_devs(log_type, rs, NULL, 0);
if (!sz) {
- syslog(LOG_ERR, msg[0]);
+ syslog(LOG_ERR, "%s", msg[0]);
return;
}
str = dm_malloc(++sz);
if (!str) {
- syslog(LOG_ERR, msg[1]);
+ syslog(LOG_ERR, "%s", msg[1]);
return;
}
_______________________________________________
Ataraid-list mailing list
Ataraid-list@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/ataraid-list
