> >Let's avoid the superfluous allocation and take Ians patch. > >Thanks, >Heinz > Heinz, Removing unnecessary memory allocating and copying is a good idea. I'm glad that the -r -E issue is solved. I have used the same memory allocation policy in the current implementation and would like to hear your opinions. The extra memory allocation is used to simplify memory relocation in metadata creation (you'll see the code soon) and reduce the chance to make error because of the properties of ISW metadata. The ISW metadata has variable length and its on-disk location is that the first sector at the back of the other sectors in sequence. Also the size of volume data (without the header) is smaller than one sector so with an extra sector, the memory adjustment occurs only after a volume is created. Thanks, Ying _______________________________________________ Ataraid-list mailing list Ataraid-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/ataraid-list