Re: hylafax PKGBUILD contains typo - '$spkgdir' line 55

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Tue, Aug 9, 2011 at 4:21 PM, David C. Rankin
<drankinatty@xxxxxxxxxxxxxxxxxx> wrote:
>
> ...
>
>  install -D -m 755 $srcdir/${pkgname}-${pkgver}/util/notify.awk \
>        $spkgdir/var/spool/hylafax/bin/notify.awk
>
> ...
>
>  If you build with write permission for /var/spool/hylafax (i.e. root) you
> would have removed the notify.awk file from the installed version of
> hylafax. (who builds as root :)

100% unrelated, but this is why my dirs *always* have a trailing `/`
... better to fail trying to remove a nonexistent `var/...` then
*gasp* the alternative `/var/<oops>` ....

... i wish everyone else did this too.  make it very easy to
detect/react when absolute fragments are appended (causes a double
`//`), naturally relative, fails more gracefully, obviates the fact
it's not a file, and avoids hacky code trying to remove PRECEDING `/`s
that MAY or MAY NOT exist (very annoying).

but yeah ... bugtracker ;-)

-- 

C Anthony


[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux