[PATCH] depmod: do not update module dependencies on boot

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



Hi guys,

I'm looking through initscripts to make sure systemd is compatible. In
doing so I think I ran across the following possible simplification of
rc.sysinit.

Comments? I'd be especially interested in hearing about usecases where
the attached patch would lead to regressions.

-----

Running depmod on boot should not be necessary as the packages
installing modules should be responsible for updating the dependencies
themselves (and they do, at least the packages I looked through).

Furthermore, as modules can be loaded very early in boot (by e.g.
udev), but depmod can only be called after root is mounted rw, we can
not rely on depmod fixing broken module dependencies.

Signed-off-by: Tom Gundersen <teg@xxxxxxx>
---
 rc.sysinit |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/rc.sysinit b/rc.sysinit
index 1dfae33..dfb0050 100755
--- a/rc.sysinit
+++ b/rc.sysinit
@@ -351,8 +351,6 @@ if [[ $NISDOMAINNAME ]]; then
       status "Setting NIS Domain Name: $NISDOMAINNAME"
/bin/nisdomainname "$NISDOMAINNAME"
 fi

-status "Updating Module Dependencies" /sbin/depmod -A
-
 # Flush old locale settings
 : >| /etc/profile.d/locale.sh
 /bin/chmod 755 /etc/profile.d/locale.sh
--
1.7.4.1


[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux