Re: [PATCH 1/2] kill_everything: Reduce number of -f tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



Am 08.09.2010 06:16, schrieb Victor Lowther:
> On Tue, Sep 7, 2010 at 10:47 PM, Dave Reisner <d@xxxxxxxxxxxxxx> wrote:
>> Instead of checking for the existance of a file in /var/run/daemons on
>> every iteration, handle the null case by setting nullglob. The shopt
>> call is done inside a subshell as to not bother the environment since we
>> may be going to runlevel 1 only temporarily.
> 
> I thought about just enabling nullglobs and extglobs unconditionally
> in functions, but decided that was too likely to get objections no
> matter how unlikely breakage was. :)

As for nullglob, I do think it is useful and enabling it might be useful
in so many places - I didn't even know this option, it would have been
useful for me before. I am in favor of enabling nullglob in function and
dropping that subshell.

Do we need extglob anywhere? I don't think so.

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux