On Tue, Sep 7, 2010 at 10:47 PM, Dave Reisner <d@xxxxxxxxxxxxxx> wrote: > On Tue, Sep 07, 2010 at 10:32:28PM +0200, Thomas Bächler wrote: >> Am 30.06.2010 23:47, schrieb Victor Lowther: >> > Despite efforts to make the initscripts POSIX, we use bash 4.0 features. >> > >> > Bashifying this framework should result in about a 30% speedup, assuming no >> > IO latency and that all programs we call also take zero time. :) >> >> I just pushed the patches - I was going to do more review of some of >> them, but I am apparently too busy. Please post any patches (especially >> if a correction of patch 21 is needed, I haven't finished reading the >> discussion) rebased on the current initscripts.git. >> > > I'm noticing that in general, the vim modelines aren't followed. Not > sure what editor was used to rebase these scripts, but the mix of tabs > and spaces for indents is somewhat irritating. I'm about to send a pair of > patches (neither of which address this) but which follow the modeline. Blame my ongoing Emacs education. I learned about (custom-set-variables '(indent-tabs-mode nil)) after doing most of the work, and dropped the whitespace cleanup patches due to size. Otherwise, I ignored the vim modelines -- 2 characters per indentation is not really enough, and most of the preexisting code happily ignored it anyways. > d >
